GSoC 2010 – week summary: August 2nd – August 8th

This week I decided to do the code cleaning. I reviewed each and every file and improved naming, comments, and other minor readability issues. I also largely modified some tests, mainly older ones where I’ve been using bad approach to test cases (named like “methodNameWorks()” ;-)). I also improved code coverage (it’s now way more than 80%). I realized that it’s good to read my own code after a while because I can then catch out some unclear naming issues and strange descriptions, which appeared to be understandable back when I was writing them :-).

I planned to create the Validators this week and I even have some code in my working copy, but I need more time. As the Parsers created earlier provide pretty useful functionality, I would like to support all of it in Validators using options property of AbstractValidator class. Initially I wanted to do quite a few simple Validators (like DecimalNumberValidator, PercentNumberValidator, and similar for date and time), but now I think that two classes (NumberValidator and DatetimeValidator) with options for configuring how they work will be a better solution.

I also need to remove few more issues (like magic strings as parameters, and lack of validation for these – why PHP still has no Enum type?).

There is a pencils down deadline after the next week (August 16th). I won’t be allowed to write any more code after. Fortunately almost everything what I planned to do and what I described in my proposal is done. I will write a nice documentation chapter and all should be OK ;-).

Tags: ,

  • Great work! I just saw the updates through SVN but it seems like you were hyperproductive or in "flow". ;)
  • Nah, it was only the cleaning ;-). Thank you!
blog comments powered by Disqus